Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: catch a few NoneType exceptions #81

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Hotfix: catch a few NoneType exceptions #81

merged 2 commits into from
Nov 25, 2024

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Nov 22, 2024

While turning containers on and off, I noted that federation's heartbeat daemon gets very unhappy if Vault is sealed and keeps throwing exceptions for NoneTypes. These fixes should help.

Before this, you can see what I mean by stopping the vault container. Federation service will start respawning the heartbeat process over and over because servers is None. If you recompose federation at this point, you'll also see more exceptions thrown during initialization.

After pulling this fix and recomposing federation, you should see that it more gracefully handles the sealed vault in both cases.

To get everything working again, start vault again and restart vault-runner. That will unseal the vault. If you wait about a minute for opa-runner and vault-runner to refresh their tokens, you can recompose federation and everything should be as it was.

@daisieh daisieh requested a review from OrdiNeu November 22, 2024 06:14
Copy link
Contributor

@OrdiNeu OrdiNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✔️ I'll note that even after recomposing vault & federation with this though, that federation won't setup properly. I don't know if that's in the scope of this ticket.

@daisieh daisieh merged commit 3452782 into develop Nov 25, 2024
1 check passed
@daisieh daisieh deleted the hotfix/none branch November 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants