DIG-1836: Fix Snyk vulnerabilities #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was more complicated because I had to replace the gevent library with an asynchronous requests thing: I went with aiohttp; it led to minimal changes, I think. You can test this on a local build by adding several of your own servers to the federation and then doing any sort of federation call with unsafe = True.
To really see that we are truly asynchronous, you can put in
await asyncio.sleep(5)after line 306 in federation.py to make it pause before going on; you'll see that the total time for the federated call is on the order of 5 seconds and not 5 * (servers) seconds.I also changed heartbeat so that it logs errors into the logger and not a separate internal file.