Update to new authZ model #262

justin-ys · 2023-06-02T17:31:07Z

Do not merge, will not work until new AuthX model is implemented in Candig
Switches htsget to new authX library functions

daisieh · 2023-06-05T22:02:53Z

This branch is based on an old version of HTSget. Can you pull latest from stable and rebase?

…into new-auth-model

justin-ys · 2023-06-06T14:11:54Z

Should be updated now.

kcranston · 2023-08-31T15:15:59Z

htsget_server/authz.py

@@ -15,15 +15,16 @@ def is_authed(id_, request):
        print("WARNING: TEST MODE, AUTHORIZATION IS DISABLED")
        app.logger.warning("WARNING: TEST MODE, AUTHORIZATION IS DISABLED")
        return 200 # no auth
-    if is_site_admin(request):
-        return 200
    if "Authorization" in request.headers:
        authed_datasets = get_authorized_datasets(request)


I don't think we need to get the list of authed_datasets here. I think we can simply use the id to get the dataset name and pass that with the other request info to is_permissible.

Update to new authZ model

d5bc3d1

justin-ys added 2 commits June 6, 2023 09:57

Update to new authZ model

cf101be

Merge branch 'new-auth-model' of https://github.com/CanDIG/htsget_app …

eb899a9

…into new-auth-model

kcranston reviewed Aug 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to new authZ model #262

Update to new authZ model #262

justin-ys commented Jun 2, 2023 •

edited

Loading

daisieh commented Jun 5, 2023

justin-ys commented Jun 6, 2023

kcranston Aug 31, 2023

Update to new authZ model #262

Are you sure you want to change the base?

Update to new authZ model #262

Conversation

justin-ys commented Jun 2, 2023 • edited Loading

daisieh commented Jun 5, 2023

justin-ys commented Jun 6, 2023

kcranston Aug 31, 2023

Choose a reason for hiding this comment

justin-ys commented Jun 2, 2023 •

edited

Loading