Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return response with standard dicts #155

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Return response with standard dicts #155

merged 4 commits into from
Nov 10, 2023

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Nov 10, 2023

Would it cause a lot of downstream problems if we were to return something more like this for the ingest endpoints?

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
chord_metadata_service/mohpackets/api_ingest.py 64.48% <100.00%> (+0.19%) ⬆️

📢 Thoughts on this report? Let us know!

@daisieh daisieh requested a review from SonQBChau November 10, 2023 05:35
SonQBChau
SonQBChau approved these changes Nov 10, 2023
View reviewed changes
Copy link

@SonQBChau SonQBChau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and approved

@daisieh daisieh merged commit b0d3e98 into develop Nov 10, 2023
@daisieh daisieh deleted the daisieh/json-results branch November 10, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SonQBChau SonQBChau SonQBChau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daisieh @SonQBChau