Cleanup #198
Merged
Cleanup #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #198 +/- ##
========================================
Coverage 94.45% 94.45%
========================================
Files 34 34
Lines 3555 3555
========================================
Hits 3358 3358
Misses 197 197 ☔ View full report in Codecov by Sentry. |
SonQBChau
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to update everything so that the containers all use
opa-service-tokeninstead ofopa-root-token, so this is fixed here. I also deleted CANDIG_OPA_SITE_ADMIN_KEY and updated (with placeholder, will fix before merge) the version of authx.This should just be a code review; testing will happen later in a CanDIGv2 PR.