Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-1584: remove all the unused discovery endpoints #199

Merged
merged 1 commit into from
May 10, 2024

Conversation

SonQBChau
Copy link

@SonQBChau SonQBChau commented May 1, 2024

What's new

  • Remove all the unused discovery endpoints
    • discover_specimens
    • discover_sample_registrations
    • discover_primary_diagnoses
    • discover_treatments
    • discover_chemotherapies
    • discover_hormone_therapies
    • discover_radiations
    • discover_immunotherapies
    • discover_surgeries
    • discover_follow_ups
    • discover_biomarkers
    • discover_comorbidities
    • discover_exposures
  • These endpoints are not in use and could bring privacy concerns
  • Refer to this PR if we want to bring back any (unlikely since it would need a new approach)
  • Move side_bar discovery to the correct section
  • Clean up

How to test

  • Open swagger-UI and confirm the endpoints no longer there

Note: don't merge into develop until after demo

- These endpoints are not in used and could bring privacy concern
- Refer to this PR if we want to bring back any (unlikely since it would need a new approach)
- Move side_bar discovery to the correct section
- Clean up
@SonQBChau SonQBChau marked this pull request as ready for review May 1, 2024 16:16
@SonQBChau SonQBChau requested a review from yavyx May 1, 2024 16:16
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (043f103) to head (a8e671b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #199      +/-   ##
===========================================
+ Coverage    94.45%   95.11%   +0.65%     
===========================================
  Files           34       34              
  Lines         3555     3503      -52     
===========================================
- Hits          3358     3332      -26     
+ Misses         197      171      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mshadbolt mshadbolt changed the title remove all the unused discovery endpoints DIG-1584: remove all the unused discovery endpoints May 1, 2024
Copy link

@yavyx yavyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused endpoints are removed, LGTM

@SonQBChau SonQBChau merged commit 04d9a4e into develop May 10, 2024
6 checks passed
@SonQBChau SonQBChau deleted the sonchau/disable_discovery branch May 10, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants