Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-1768 : update factories, synth data #263

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

mshadbolt
Copy link

Update factories to the new model

Update synth data jsons

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (cd4a068) to head (e5c9112).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #263      +/-   ##
===========================================
+ Coverage    93.02%   93.39%   +0.36%     
===========================================
  Files           35       35              
  Lines         2480     2482       +2     
===========================================
+ Hits          2307     2318      +11     
+ Misses         173      164       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mshadbolt mshadbolt requested a review from SonQBChau September 16, 2024 23:50
Copy link

@SonQBChau SonQBChau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshadbolt mshadbolt merged commit 967ccaa into develop Sep 18, 2024
6 checks passed
@mshadbolt mshadbolt deleted the mshadbolt/synth-data-3-1 branch September 18, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants