BattMonitor: minimum voltage option for aggregate monitors #114
Conversation
loki077
force-pushed
the
feature/SW-97-add-option-for-vtol-battmon-to-report-min-voltage
branch
from
82a550f to
ad09da0
Compare
robertlong13
force-pushed
the
feature/SW-97-add-option-for-vtol-battmon-to-report-min-voltage
branch
from
ad09da0 to
a76d6ba
Compare
robertlong13
changed the title
|
I've fixed and reworked this PR a bit. The option now also applies both to "Sum" type monitors as well as "ESC" type. I also reserved the (1U<<7) option to make the upstream PR easier, since that option has been taken now. I tested in SITL on a sum monitor, but this needs testing on an iron bird with an ESC monitor. |
robertlong13
requested review from
a user and
Pradeep-Carbonix
and removed request for
robertlong13 and
Pradeep-Carbonix
ghost
requested a review
from 
|
@Jono453 can you help with testing with it. Will need to emulate failure on CPN on iron bird without actually using ESC. We can discuss the test stages. |
robertlong13
force-pushed
the
feature/SW-97-add-option-for-vtol-battmon-to-report-min-voltage
branch
from
15f0f8a to
7938050
Compare
Allows aggregate monitors like Sum and ESC to report the minimum voltage instead of the average voltage. This is useful for systems with multiple isolated batteries where the lowest voltage is the limiting factor. SW-97
Pradeep-Carbonix
force-pushed
the
feature/SW-97-add-option-for-vtol-battmon-to-report-min-voltage
branch
from
7938050 to
6944422
Compare
|
I have done the review of code. But can't approve it as I raised the PR @robertlong13 @Pradeep-Carbonix can you review and approve the PR. |
done |
robertlong13
deleted the
feature/SW-97-add-option-for-vtol-battmon-to-report-min-voltage
branch
|
Upstream open (likely merge tomorrow): ArduPilot/ardupilot#28227 |
O8 has left and right VTOL batteries, we are really interested in the minimum voltage between the two batteries instead of average voltage. The ESC battery monitor reports the average of the voltage of all connected ESCs.
This change will add option on BATT_Monitor to report ESC lowest voltage and not sum.
Testing is still pending to see the results.
SW-97