Change to include-based hwdef #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit leads to zero changes to the output of hwdef.h for both CarbonixF405 and CarbonixL496. SW-159
robertlong13
added
the
CX_NO_CODE_CHANGE
|
This test won't work actually, nevermind. Hwdefs embed in the ROMFS, so even for non-code changes, that check will fail (additionally, we actually test before building if the hwdef has changed and auto fail if it does). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a subtask of SW-159 and is related to this other PR: #136
But I'm going to make these two commits a separate PR to prove no code changes by these two before I start changing a bunch of things.