Engine ReCrank Max Try Rebased for CxPilot-7 #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
force-pushed
the
CxPilot-7
branch
from
2403a58 to
177753a
Compare
Added Param MAX_RETRY which If set 0 or less, then there is no limit to retrials. If set to a value greater than 0 then the engine will retry starting the engine this many times before giving up.
robertlong13
force-pushed
the
feature/SW-314-limits-on-cranking-retries-when-engine-failure
branch
from
3f03b98 to
4c1c2a6
Compare
robertlong13
approved these changes
Sep 17, 2024
| state = ICE_STARTING; | ||
| // check if we should retry starting the engine | ||
| if (max_crank_retry <= 0 || crank_retry_ct < max_crank_retry) { | ||
| GCS_SEND_TEXT(MAV_SEVERITY_INFO, "Starting engine"); |
There was a problem hiding this comment.
A suggestion - if we can display the attempt count on GCS, might help to check when max_crank_retry is high number
GCS_SEND_TEXT(MAV_SEVERITY_INFO, "Starting engine - attempt %d", crank_retry_ct);
| @@ -175,6 +175,13 @@ const AP_Param::GroupInfo AP_ICEngine::var_info[] = { | |||
| // @Values: 0:Forward,1:Reverse | |||
| AP_GROUPINFO("CRANK_DIR", 19, AP_ICEngine, crank_direction, 0), | |||
|
|
|||
| // @Param: STRT_MX_RTRY | |||
| // @DisplayName: Maximum number of retries | |||
| // @Description: If set 0 then there is no limit to retrials. If set to a value greater than 0 then the engine will retry starting the engine this many times before giving up. | |||
There was a problem hiding this comment.
if 0, then Engine max crank attempts reached
|
Closing this. We'll reopen something with the upstream gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.