Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUA : restructure to manage prearm-checks #261

Merged
merged 7 commits into from
Dec 30, 2024

Conversation

Pradeep-Carbonix
Copy link
Contributor

To manage pre-arm checks from multiple modules, this is subdivided into

  • cx_build_in_test.lua : main module for built in tests
  • cx_modules : directory containing all sub modules
  • cx_utils : libraries support other modules

Copy link
Collaborator

@robertlong13 robertlong13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. Almost there.

I think we should tidy up the naming a bit. I'm not a fan of the way we've been putting cx in everything (maybe I'll have to fight @loki077 on that). Let's have the three of us hash that out in person.

@loki077
Copy link
Contributor

loki077 commented Dec 19, 2024

Cx/carbonix as prefix is a just an easy way to find all carbonix files no other reason. I know the files are already in a folder which is mostly related to carbonix.

But I am not very attached to "cx_" to have a fight on this 😅

@loki077
Copy link
Contributor

loki077 commented Dec 19, 2024

Also I will merge the ci speed up PR prior to this so the simlink won't be needed.

@loki077
Copy link
Contributor

loki077 commented Dec 19, 2024

Is the auto test part of the same PR ? @Pradeep-Carbonix @robertlong13

@robertlong13
Copy link
Collaborator

I was originally planning it to be, but it's too tightly coupled with my SITL PR.

What I'm now proposing is to make the CX_BIT auto test part of my SITL PR, then rebase this PR on that one and confirm it still passes.

@Pradeep-Carbonix
Copy link
Contributor Author

This is looking really good. Almost there.

I think we should tidy up the naming a bit. I'm not a fan of the way we've been putting cx in everything (maybe I'll have to fight @loki077 on that). Let's have the three of us hash that out in person.

Changes the filesnames from :
├── cx_built_in_test.lua
├── cx_modules
│   └── cx_esc.lua
│ ├── cx_efi.lua [*Implemented in separate commit]
└── cx_utils
├── cx_aircraft.lua
└── cx_msg.lua

to this :
├── cx_built_in_test.lua
├── bit_subsystems
│   └── esc.lua
│ ├── efi.lua [*Implemented in separate commit]
└── utils
├── aircraft.lua
└── msg.lua

@Pradeep-Carbonix Pradeep-Carbonix force-pushed the feature/SW-96-restructure-of-lua-script branch from e4d1781 to cd1dc59 Compare December 23, 2024 05:16
@robertlong13 robertlong13 force-pushed the feature/SW-96-restructure-of-lua-script branch 3 times, most recently from 4ef5813 to 3bac6fe Compare December 29, 2024 22:26
@robertlong13 robertlong13 force-pushed the feature/SW-96-restructure-of-lua-script branch 2 times, most recently from 721f85f to 3885a97 Compare December 30, 2024 01:02
Copy link
Contributor

@loki077 loki077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with one Minor fix)

Tools/autotest/autotest.py Outdated Show resolved Hide resolved
@robertlong13 robertlong13 force-pushed the feature/SW-96-restructure-of-lua-script branch from 3885a97 to 03f7704 Compare December 30, 2024 02:46
@robertlong13 robertlong13 force-pushed the feature/SW-96-restructure-of-lua-script branch from 03f7704 to 0afcc7c Compare December 30, 2024 02:50
@loki077 loki077 merged commit a895396 into CxPilot-7 Dec 30, 2024
57 checks passed
@loki077 loki077 deleted the feature/SW-96-restructure-of-lua-script branch December 30, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants