-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUA : restructure to manage prearm-checks #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good. Almost there.
I think we should tidy up the naming a bit. I'm not a fan of the way we've been putting cx
in everything (maybe I'll have to fight @loki077 on that). Let's have the three of us hash that out in person.
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/scripts/cx_modules/esc.lua
Outdated
Show resolved
Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/scripts/cx_utils/cx_aircraft.lua
Outdated
Show resolved
Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/scripts/cx_utils/cx_msg.lua
Outdated
Show resolved
Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/CubeOrange-Ottano/scripts/cx_utils/cx_aircraft.lua
Outdated
Show resolved
Hide resolved
Cx/carbonix as prefix is a just an easy way to find all carbonix files no other reason. I know the files are already in a folder which is mostly related to carbonix. But I am not very attached to "cx_" to have a fight on this 😅 |
Also I will merge the ci speed up PR prior to this so the simlink won't be needed. |
Is the auto test part of the same PR ? @Pradeep-Carbonix @robertlong13 |
I was originally planning it to be, but it's too tightly coupled with my SITL PR. What I'm now proposing is to make the CX_BIT auto test part of my SITL PR, then rebase this PR on that one and confirm it still passes. |
Changes the filesnames from : to this : |
e4d1781
to
cd1dc59
Compare
4ef5813
to
3bac6fe
Compare
libraries/AP_HAL_ChibiOS/hwdef/CubeOrange-Ottano/scripts/utils/aircraft.lua
Outdated
Show resolved
Hide resolved
721f85f
to
3885a97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with one Minor fix)
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/scripts/cx_built_in_test.lua
Outdated
Show resolved
Hide resolved
3885a97
to
03f7704
Compare
03f7704
to
0afcc7c
Compare
To manage pre-arm checks from multiple modules, this is subdivided into