AP_ICEngine : Fuel pump implementation and cleanup #267
+32
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pradeep-Carbonix
requested review from
robertlong13,
loki077 and
Jono453
and removed request for
Jono453
robertlong13
force-pushed
the
feature/SW-282-fuel-pump-power-control
branch
from
a68c66f to
29810f1
Compare
New aircraft have the fuel pump connected to the TCA9554 instead of the ECU. This commit simply runs the fuel pump when the engine is running.
robertlong13
force-pushed
the
feature/SW-282-fuel-pump-power-control
branch
from
29810f1 to
7fc8673
Compare
|
LGTM - Will approve on the seeing the bird test results. |
loki077
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
@robertlong13 or @Pradeep-Carbonix Please, make a test ticket for this in Flight Engineering where this as to be fully tested on ground before flying.
Also, a confirmation is needed from Electronics team on the verification of driving capability of the MOSFET for fuel pump is correct.
|
@robertlong13 once you have done the review merge this. |
|
I don't want to merge it until it gets at least a single simple test in an actual aircraft. I don't totally trust the bench test we did. I basically wrote this one, so I'll abstain from review. |
|
@robertlong13 in that case this will be marked for 7.2.0 Release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.