CarbonixCommon: bit_esc: suppress nil warnings #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertlong13 CRC will change too |
|
Also, as the CI suggest the if statement is empty. I think lua is fine with it but not the linter. |
It doesn't. Modules don't count, only top-level scripts. |
These are caused by two well-understood race conditions and we don't need to put them up on the messages tab anymore. This will be fixed properly in a future PR. Also, driveby fix for resetting the nil counters. These should be done every time we get good data, not just when recoving from telemetry loss.
robertlong13
force-pushed
the
feature/SW-533-cx-bit-suppress-nil-warnings
branch
from
64e7301 to
a80abda
Compare
Now that we have suppressed the nil warnings, we can correctly assert that we should not get any warnings normally from CX_BIT.
robertlong13
force-pushed
the
feature/SW-533-cx-bit-suppress-nil-warnings
branch
from
6ff7f43 to
6ed8b45
Compare
loki077
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are caused by two well-understood race conditions and we don't
need to put them up on the messages tab anymore. This will be fixed
properly in a future PR.
Also, driveby fix for resetting the nil counters. These should be done
every time we get good data, not just when recoving from telemetry loss.