-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sw 48 can servo feature addition #97
Feature/sw 48 can servo feature addition #97
Conversation
Pradeep-Carbonix
commented
Jan 19, 2024
- Update uavcan.equipment.power.CircuitStatus
- update uavcan.equipment.device.Temperature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should extend the onboard log message instead of adding new messages. If you check the CSRV message in master, it has voltage, current, and temperatures now. We should match master's message.
1. Update uavcan.equipment.power.CircuitStatus - Voltage, Current and Error_flags 2. update uavcan.equipment.device.Temperature - Temperature and Error_flags
e1e5c4f
to
9cfda82
Compare
Thanks for suggesting to make these messages independent. The new generic names will not limit them to only mean servo/actuator logs |
For tracking For future reference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code structure looks good. Just please confirm in the comments it is been tested on a hardware as I don't have to test on. Also, @Pradeep-Carbonix if you have any test report put a link here which will be good for reference.
@robertlong13 do you have any comments on this PR? or good to go ahead and merge? |
Check the logs here : \Dropbox (Carbonix Company)\Carbonix Engineering Team Folder\07_Test_Results\MKS HBL3850 |