Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4564: Modified example/ordering so that it sends unique elements from data provider #495

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

Marcin-Radecki
Copy link
Contributor

  • example/ordering binary now produces unique DataProvider input, so that the successful finish condition is that all nodes need to see at least one integer for union of all node's DataProvider items,
  • reworked run.sh:
    • support for passing unit creation delay (was the defult_unit_creation_delay(), which is 5000 ms, that is far greater than production values)
    • added better crash simulation - now run.sh kills node process, so it cannot anticipate crash

Copy link

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, too bad it doesn't really test the censorship thing, but that is my bad. One tiny doc comment.

examples/ordering/run.sh Show resolved Hide resolved
@Marcin-Radecki Marcin-Radecki added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 7dda99f Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants