A0-4563: Introduce notion of non-direct parents in Extender #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcin-Radecki
had a problem deploying
to
Autobump version
GitHub Actions
Failure
|
Please make sure the following happened
|
Marcin-Radecki
commented
Dec 11, 2024
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
changed the title
Marcin-Radecki
changed the title
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
timorleph
approved these changes
Dec 13, 2024
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
UnitWithParentstrait so that it will be possible to distinguish direct and non-direct parents of a unit. Those changes are required for later changes in DAG reconstruction and validation. This change must be a no-op from the algorithm perspective. I am not going to uncomment UT added recently just yet,