Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add vesting backend and frontend #134

Merged
merged 30 commits into from
Sep 23, 2024
Merged

Feat/add vesting backend and frontend #134

merged 30 commits into from
Sep 23, 2024

Conversation

djeck1432
Copy link
Contributor

  1. Added new routing
  2. Added new logic for getEvents
  3. Added new .env.example file

@djeck1432 djeck1432 marked this pull request as draft September 6, 2024 20:08
tensojka
tensojka reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@tensojka tensojka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it? How's the latency?

backend/.env.example Outdated Show resolved Hide resolved
backend/src/starknet.ts Outdated Show resolved Hide resolved
@tensojka tensojka marked this pull request as ready for review September 12, 2024 16:42
@djeck1432 djeck1432 requested a review from tensojka September 21, 2024 18:51
@tensojka tensojka changed the title Feat/add vesting backend Feat/add vesting backend and frontend Sep 23, 2024
tensojka
tensojka requested changes Sep 23, 2024
View reviewed changes
backend/.env.example Outdated Show resolved Hide resolved
frontend/src/components/VestingTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/VestingTable.tsx Outdated Show resolved Hide resolved
backend/src/starknet.ts Outdated Show resolved Hide resolved
frontend/src/components/VestingTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/VestingTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/VestingTable.tsx Show resolved Hide resolved
@djeck1432 djeck1432 requested a review from tensojka September 23, 2024 14:00
tensojka
tensojka reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@tensojka tensojka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rewritten the event fetching and cache structure in the backend into a more maintainable form as I found it hard to communicate what changes were needed (see the do..while commit which did not lead to code that would be any more maintainable).

The cache structure was also improved.

backend/src/starknet.ts Outdated Show resolved Hide resolved
tensojka
tensojka reviewed Sep 23, 2024
View reviewed changes
backend/src/starknet.ts Outdated Show resolved Hide resolved
@tensojka tensojka merged commit 0edf935 into CarmineOptions:master Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tensojka tensojka tensojka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djeck1432 @tensojka