interface: start pulling out the stage concept #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianohara
force-pushed
the
ian-microcrontroller-simulation
branch
from
2911bad to
d2a945f
Compare
ianohara
changed the base branch from
ian-microcrontroller-simulation
to
master
ianohara
force-pushed
the
ian-stage-breakout
branch
2 times, most recently
from
4005e01 to
73fd655
Compare
ianohara
force-pushed
the
ian-stage-breakout
branch
from
a415d54 to
00ef16c
Compare
ianohara
force-pushed
the
ian-stage-breakout
branch
from
00ef16c to
359951c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is starting work on the "X, Y, Z Motion stage" task in https://www.notion.so/cephla/Headless-Mode-and-Scripting-Design-1452dfbf6ae480c3b444ee0847f532a5 .
It's gonna be a tricky one - we have stage-like code in a lot of places. But the net result is that we will end up deleting a ton of tricky code (eg: all the unit conversion stuff) from a bunch of places, and instead have it all focused in one location.
The hard part isn't the stage implementation, it's finding all the places we do stage-like stuff, fixing them, and making sure nothing is broken in the process.