Fixed GUI crash on invalid walletconnect request #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiaMineJP
added
the
Fixed
|
Needs to merge #2477 prior to this PR |
markelrod
previously approved these changes
Sep 11, 2024
ChiaMineJP
force-pushed
the
cmj.fix-gui-crash-on-offer-submission
branch
2 times, most recently
from
e1dec8a to
9122fee
Compare
ChiaMineJP
force-pushed
the
cmj.fix-gui-crash-on-offer-submission
branch
from
9122fee to
d2009e3
Compare
markelrod
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2455
Through walletconnect, invalid offer with null amount offer item could be sent to GUI.
In that case, GUI keeps crashing until the walletconnect endpoint gives up to send requests.
This PR catches exception raised during rendering walletconnect request confirmation dialog and opens the
AlertDialogwith a message notifying an invalid walletconnect request arrives, and sends rejection to walletconnect endpoint.