-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap with writer #19119
Open
wjblanke
wants to merge
14
commits into
main
Choose a base branch
from
writewrapwjb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wrap with writer #19119
+25
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjblanke
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Jan 10, 2025
Pull Request Test Coverage Report for Build 12731382263Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
The db_wrapper code allows read operations to use the current write connection if it is active.
Currently the syncing operation uses distinct writes and reads which means write operations are on the writer connection and read operations are on one of the read connections across different threads.
To make life easier for sqlite, this PR wraps block syncs within one db_wrapper writer. The block sync db_wrapper operations then will use the write connection whether it is for reading or writing. The write connection always has an up to date view of the DB.
Current Behavior:
Block sync operations use multiple connections and threads
New Behavior:
Block sync operations use the writer connection
Testing Notes:
This may cause a reduction in concurrency because the db_wrapper write has its own lock. Performance would be the main concern here although with less coherency issues things should be faster.