Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on windows and julia 1.1 #224

Closed
wants to merge 1 commit into from
Closed

test on windows and julia 1.1 #224

wants to merge 1 commit into from

Conversation

vlandau
Copy link
Member

@vlandau vlandau commented Feb 25, 2020

to address appveyor failures mentioned to #223

to address appveyor failures mentioned to #223
@vlandau
Copy link
Member Author

vlandau commented Feb 25, 2020

Appear to be getting the same failures on Windows in Travis.

@vlandau
Copy link
Member Author

vlandau commented Feb 25, 2020

Appear to be getting the same failures on Windows in Travis

@ViralBShah
Copy link
Member

Can you rebase on the latest master?

@ViralBShah
Copy link
Member

ViralBShah commented Feb 25, 2020

The failure is the same as #188. Looks like a windows mmap issue - perhaps it is running out of resources or something. @ranjanan Does this test fail when we run it standalone as well?

@ranjanan
Copy link
Member

Yes, these tests fail on Windows VMs I have tested on as well. Definitely related to #188. Our plan so far is to implement multi-threading to solve this.

@vlandau
Copy link
Member Author

vlandau commented Feb 25, 2020

Can you rebase on the latest master?

I should already be up to date with the latest master on this branch

@coveralls
Copy link

coveralls commented Feb 25, 2020

Pull Request Test Coverage Report for Build 580

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 85.399%

Totals Coverage Status
Change from base Build 579: -0.02%
Covered Lines: 1550
Relevant Lines: 1815

💛 - Coveralls

@vlandau
Copy link
Member Author

vlandau commented Feb 25, 2020

The failure is the same as #188. Looks like a windows mmap issue - perhaps it is running out of resources or something. @ranjanan Does this test fail when we run it standalone as well?

Let's close this PR then?

@vlandau
Copy link
Member Author

vlandau commented Feb 25, 2020

Noticing windows tests did pass on Julia 1.3 in Travis (I think it didn't pass on 1.3 in Appveyor?)

@ViralBShah
Copy link
Member

Let's leave it open a little while longer. I'll see if there's an easy fix. @ranjanan Do you want to avoid the use of Travis windows?

@ViralBShah
Copy link
Member

ViralBShah commented Feb 26, 2020

@vlandau I've made you an owner of the Circuitscape github org.

@ranjanan
Copy link
Member

ranjanan commented Mar 15, 2020

I've merged this with #225 where I'll reduce the number of tests that I run every single time. So #225 supersedes this.

@ranjanan ranjanan closed this Mar 15, 2020
@vlandau vlandau deleted the vl/travis-windows branch June 24, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants