Reformulate IMEX ARK to correctly account for Newton residuals and DSS #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR reformulates the IMEX ARK timestepping scheme, as our previous version was not accounting for the inter-stage effects of DSS and residuals from Newton's method. The new formulation has been checked by Oswald and Tapio.
Since this new formulation is somewhat more complicated, I tried making things easier to read by rewriting all linear combinations as broadcast expressions. This involved replacing
SparseCoeffs
withSparseTuple
s, and it had the added benefit of increasing loop fusion (i.e., it reduced the number of broadcast expressions executed on each stage).To-do
dss!(field_vectors...)
, and use it to avoid adding an extra DSS operation on each stage.Content