azure-fence.py: use azure-identity instead of msrestazure as it has been deprecated

[varkoly]

Implementing cloud environment setup with azure.identy

[knet-jenkins]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-602/1/input

[oalbrigt]

retest this please

[oalbrigt]

Looks good to me, but there's an indentation mismatch on one or more lines making CI fail (TabError: inconsistent use of tabs and spaces in indentation).

[knet-jenkins]

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/PR-602/3/input

[oalbrigt]

retest this please

[oalbrigt]

Looks good to me.

I'll do some testing later this week, and merge after I've confirmed it's working as expected.

[oalbrigt]

The azure-identity part doesnt work with the other libraries it seems like, and also azure-common still requires msrestazure, so we still need it even if we dont use it in our code.

NOTE: It seems like the RHEL8 code needs to be updated based on the RHEL9 azure_fence.py and possibly fence_azure_arm, so that output is just in case it might give some additional pointers on top of the RHEL9 output.

Output from RHEL8 fence_azure_arm -o list:

Traceback (most recent call last):
  File "./fence_azure_arm", line 260, in <module>
    main()
  File "./fence_azure_arm", line 238, in main
    compute_client = azure_fence.get_azure_compute_client(config)
  File "/usr/share/fence/azure_fence.py", line 333, in get_azure_compute_client
    credentials = get_azure_credentials(config)
  File "/usr/share/fence/azure_fence.py", line 315, in get_azure_credentials
    cloud_environment=cloud_environment
  File "/usr/lib/fence-agents/bundled/azure/msrestazure/azure_active_directory.py", line 352, in __init__
    self._configure(**kwargs)
  File "/usr/lib/fence-agents/bundled/azure/msrestazure/azure_active_directory.py", line 89, in _configure
    auth_endpoint = self._cloud_environment.endpoints.active_directory
AttributeError: 'str' object has no attribute 'endpoints' 

From RHEL9:

Traceback (most recent call last):
  File "/root/./fence_azure_arm", line 270, in <module>
    main()
  File "/root/./fence_azure_arm", line 252, in main
    compute_client = azure_fence.get_azure_compute_client(config)
  File "/usr/share/fence/azure_fence.py", line 374, in get_azure_compute_client
    credential_scope = cloud_environment.endpoints.resource_manager + "/.default"
AttributeError: 'str' object has no attribute 'endpoints'

[oalbrigt]

After updating the agent and library based on upstream and this patch I get the same output as I got in the RHEL9 test above.