Feature 25 edit options #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisK00
requested changes
Apr 4, 2021
There was a problem hiding this comment.
Good job! Just need to look up automapper.
Automapper docs are very good https://docs.automapper.org/en/stable/Getting-started.html
| @@ -70,6 +70,19 @@ public async Task<string> AddIngredient(IngredientAddDTO ingredientAddDTO) | |||
| return ingredientAddDTO.Name; | |||
| } | |||
|
|
|||
| public async Task UpdateIngredient(string name, IngredientAddDTO ingredientAddDTO) | |||
There was a problem hiding this comment.
Ingredient services currently has this update method https://github.com/chrisK00/CRUDRecipeEF/blob/master/CRUDRecipeEF.BL.DL/Services/IIngredientService.cs
| @@ -78,6 +78,19 @@ public async Task<string> AddIngredientToRecipe(IngredientAddDTO ingredientAddDT | |||
| return recipeName; | |||
| } | |||
|
|
|||
| public async Task UpdateRecipe(string name, RecipeAddDTO recipeAddDTO) | |||
There was a problem hiding this comment.
I recommend doing it the way we did with automapper in the ingredientservice. Msg me on discord if you want me to explain if it isnt clear whats happening
| // this is super shit code, sorry | ||
| //TODO: Fix this mess | ||
| var recipe = await _recipeService.GetRecipeByName(name); | ||
| RecipeAddDTO recipeAdd = new RecipeAddDTO() { Name = recipe.Name }; |
There was a problem hiding this comment.
Automapper can fix this easily
- We need a configuration inside the AutoMapperProfiles CreateMap<from, to>
- use the mapper like this: _mapper.Map(fromObject)
| } | ||
| else if (char.ToUpper(editWhat[0]) == 'I') | ||
| { | ||
| //TODO: Not DRY, extract this and use it in common locations |
There was a problem hiding this comment.
Good idea, some sort of generic method or factory is probably the way to go.
…lacing it anyways.
Feature/97 ingredient repo
…q and if we wanna test the repo we can use in memory db
Feature/95 ingredientservice tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #25