Skip to content

Commit

Permalink
No commit message
Browse files Browse the repository at this point in the history
  • Loading branch information
NikolaRHristov committed Oct 9, 2024
2 parents a76fc8b + bb09960 commit 00b39c3
Show file tree
Hide file tree
Showing 44 changed files with 1,443 additions and 280 deletions.
32 changes: 32 additions & 0 deletions .vscode/notebooks/api.github-issues
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
[
{
"kind": 1,
"language": "markdown",
"value": "#### Config"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPO=repo:microsoft/vscode\n$MILESTONE=milestone:\"October 2024\""
},
{
"kind": 1,
"language": "markdown",
"value": "### Finalization"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPO $MILESTONE label:api-finalization"
},
{
"kind": 1,
"language": "markdown",
"value": "### Proposals"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPO $MILESTONE is:open label:api-proposal sort:created-asc"
}
]
162 changes: 162 additions & 0 deletions .vscode/notebooks/my-work.github-issues
Original file line number Diff line number Diff line change
@@ -0,0 +1,162 @@
[
{
"kind": 1,
"language": "markdown",
"value": "##### `Config`: This should be changed every month/milestone"
},
{
"kind": 2,
"language": "github-issues",
"value": "// list of repos we work in\n$REPOS=repo:microsoft/lsprotocol repo:microsoft/monaco-editor repo:microsoft/vscode repo:microsoft/vscode-anycode repo:microsoft/vscode-autopep8 repo:microsoft/vscode-black-formatter repo:microsoft/vscode-copilot repo:microsoft/vscode-copilot-release repo:microsoft/vscode-dev repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-flake8 repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-hexeditor repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-isort repo:microsoft/vscode-js-debug repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-l10n repo:microsoft/vscode-livepreview repo:microsoft/vscode-markdown-languageservice repo:microsoft/vscode-markdown-tm-grammar repo:microsoft/vscode-mypy repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-pylint repo:microsoft/vscode-python repo:microsoft/vscode-python-debugger repo:microsoft/vscode-python-tools-extension-template repo:microsoft/vscode-references-view repo:microsoft/vscode-remote-release repo:microsoft/vscode-remote-repositories-github repo:microsoft/vscode-remote-tunnels repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-unpkg repo:microsoft/vscode-vsce\n\n// current milestone name\n$MILESTONE=milestone:\"October 2024\"\n"
},
{
"kind": 1,
"language": "markdown",
"value": "## Milestone Work"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS $MILESTONE assignee:@me is:open\n"
},
{
"kind": 1,
"language": "markdown",
"value": "## Bugs, Debt, Features..."
},
{
"kind": 1,
"language": "markdown",
"value": "#### My Bugs"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open label:bug\n"
},
{
"kind": 1,
"language": "markdown",
"value": "#### Debt & Engineering"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open label:debt,engineering\n"
},
{
"kind": 1,
"language": "markdown",
"value": "#### Performance 🐌 🔜 🏎"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open label:perf,perf-startup,perf-bloat,freeze-slow-crash-leak\n"
},
{
"kind": 1,
"language": "markdown",
"value": "#### Feature Requests"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open label:feature-request milestone:Backlog sort:reactions-+1-desc\n"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open milestone:\"Backlog Candidates\"\n"
},
{
"kind": 1,
"language": "markdown",
"value": "### Personal Inbox"
},
{
"kind": 1,
"language": "markdown",
"value": "#### Triage Needed"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS is:open assignee:@me label:triage-needed\n"
},
{
"kind": 1,
"language": "markdown",
"value": "\n#### Missing Type label"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open type:issue -label:bug -label:\"info-needed\" -label:feature-request -label:under-discussion -label:debt -label:plan-item -label:upstream -label:polish -label:testplan-item -label:error-telemetry -label:engineering\n"
},
{
"kind": 1,
"language": "markdown",
"value": "#### Missing Area Label\n\nFeature area labels are light or strong blue (`1d76db` or `c5def5`) and they denote a specific feature or feature area, like `editor-clipboard` or `file-explorer`"
},
{
"kind": 2,
"language": "github-issues",
"value": "repo:microsoft/vscode assignee:@me is:open type:issue -label:\"info-needed\" -label:api -label:api-finalization -label:api-proposal -label:authentication -label:bisect-ext -label:bracket-pair-colorization -label:bracket-pair-guides -label:breadcrumbs -label:callhierarchy -label:chrome-devtools -label:code-lens -label:command-center -label:comments -label:config -label:context-keys -label:custom-editors -label:debug -label:debug-console -label:debug-disassembly -label:dialogs -label:diff-editor -label:dropdown -label:editor-api -label:editor-autoclosing -label:editor-autoindent -label:editor-bracket-matching -label:editor-clipboard -label:editor-code-actions -label:editor-color-picker -label:editor-columnselect -label:editor-commands -label:editor-comments -label:editor-contrib -label:editor-core -label:editor-drag-and-drop -label:editor-error-widget -label:editor-find -label:editor-folding -label:editor-highlight -label:editor-hover -label:editor-indent-detection -label:editor-indent-guides -label:editor-input -label:editor-input-IME -label:editor-insets -label:editor-minimap -label:editor-multicursor -label:editor-parameter-hints -label:editor-render-whitespace -label:editor-rendering -label:editor-RTL -label:editor-scrollbar -label:editor-sorting -label:editor-sticky-scroll -label:editor-sticky-scroll-decorations -label:editor-symbols -label:editor-synced-region -label:editor-textbuffer -label:editor-theming -label:editor-wordnav -label:editor-wrapping -label:emmet-parse -label:extension-activation -label:extension-host -label:extension-prerelease -label:extension-recommendations -label:extension-signature -label:extensions -label:extensions-development -label:file-decorations -label:file-encoding -label:file-explorer -label:file-glob -label:file-io -label:file-nesting -label:file-watcher -label:font-rendering -label:formatting -label:getting-started -label:ghost-text -label:git -label:github -label:github-repositories -label:gpu -label:grammar -label:grid-widget -label:icon-brand -label:icons-product -label:icons-widget -label:inlay-hints -label:inline-chat -label:inline-completions -label:install-update -label:intellisense-config -label:interactive-playground -label:interactive-window -label:javascript -label:json -label:json-sorting -label:keybindings -label:keybindings-editor -label:keyboard-layout -label:L10N -label:l10n-platform -label:label-provider -label:languages-basic -label:languages-diagnostics -label:languages-guessing -label:layout -label:lcd-text-rendering -label:list-widget -label:live-preview -label:log -label:markdown -label:marketplace -label:menus -label:merge-conflict -label:merge-editor -label:merge-editor-workbench -label:monaco-editor -label:multi-monitor -label:native-file-dialog -label:network -label:notebook -label:notebook-accessibility -label:notebook-api -label:notebook-builtin-renderers -label:notebook-cell-editor -label:notebook-celltoolbar -label:notebook-clipboard -label:notebook-code-actions -label:notebook-commands -label:notebook-commenting -label:notebook-debugging -label:notebook-diff -label:notebook-dnd -label:notebook-execution -label:notebook-find -label:notebook-folding -label:notebook-format -label:notebook-getting-started -label:notebook-globaltoolbar -label:notebook-ipynb -label:notebook-kernel -label:notebook-kernel-picker -label:notebook-language -label:notebook-layout -label:notebook-markdown -label:notebook-minimap -label:notebook-multiselect -label:notebook-output -label:notebook-perf -label:notebook-remote -label:notebook-rendering -label:notebook-serialization -label:notebook-statusbar -label:notebook-sticky-scroll -label:notebook-toc-outline -label:notebook-undo-redo -label:notebook-variables -label:notebook-workbench-integration -label:notebook-workflow -label:open-editors -label:opener -label:outline -label:output -label:packaging -label:panel-chat -label:perf -label:perf-bloat -label:perf-startup -label:php -label:portable-mode -label:proxy -label:quick-open -label:quick-pick -label:quickpick-chat -label:references-viewlet -label:release-notes -label:remote -label:remote-connection -label:remote-desktop -label:remote-explorer -label:remote-tunnel -label:rename -label:runCommands -label:sandbox -label:sash-widget -label:scm -label:screencast-mode -label:search -label:search-api -label:search-editor -label:search-replace -label:semantic-tokens -label:server -label:settings-editor -label:settings-search -label:settings-sync -label:settings-sync-server -label:shared-process -label:simple-file-dialog -label:smart-select -label:snap -label:snippets -label:splitview-widget -label:ssh -label:suggest -label:system-context-menu -label:table-widget -label:tasks -label:telemetry -label:terminal -label:terminal-accessibility -label:terminal-conpty -label:terminal-editors -label:terminal-external -label:terminal-find -label:terminal-input -label:terminal-layout -label:terminal-links -label:terminal-local-echo -label:terminal-persistence -label:terminal-process -label:terminal-profiles -label:terminal-quick-fix -label:terminal-rendering -label:terminal-shell-bash -label:terminal-shell-cmd -label:terminal-shell-fish -label:terminal-shell-git-bash -label:terminal-shell-integration -label:terminal-shell-pwsh -label:terminal-shell-zsh -label:terminal-tabs -label:testing -label:themes -label:timeline -label:timeline-git -label:timeline-local-history -label:titlebar -label:tokenization -label:touch/pointer -label:trackpad/scroll -label:tree-views -label:tree-widget -label:typescript -label:unc -label:undo-redo -label:unicode-highlight -label:uri -label:user-profiles -label:ux -label:variable-resolving -label:VIM -label:virtual-documents -label:virtual-workspaces -label:vscode-website -label:vscode.dev -label:web -label:webview -label:webview-views -label:workbench-actions -label:workbench-auxwindow -label:workbench-banner -label:workbench-cli -label:workbench-diagnostics -label:workbench-dnd -label:workbench-editor-grid -label:workbench-editor-groups -label:workbench-editor-resolver -label:workbench-editors -label:workbench-electron -label:workbench-fonts -label:workbench-history -label:workbench-hot-exit -label:workbench-hover -label:workbench-launch -label:workbench-link -label:workbench-multiroot -label:workbench-notifications -label:workbench-os-integration -label:workbench-rapid-render -label:workbench-run-as-admin -label:workbench-state -label:workbench-status -label:workbench-tabs -label:workbench-touchbar -label:workbench-untitled-editors -label:workbench-views -label:workbench-voice -label:workbench-welcome -label:workbench-window -label:workbench-workspace -label:workbench-zen -label:workspace-edit -label:workspace-symbols -label:workspace-trust -label:zoom -label:error-list -label:winget"
},
{
"kind": 1,
"language": "markdown",
"value": "### Missing Milestone"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open type:issue no:milestone -label:info-needed -label:triage-needed\n"
},
{
"kind": 1,
"language": "markdown",
"value": "#### Not Actionable"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS assignee:@me is:open label:\"info-needed\"\n"
},
{
"kind": 1,
"language": "markdown",
"value": "### Pull Requests"
},
{
"kind": 1,
"language": "markdown",
"value": "✅ Approved"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS author:@me is:open is:pr review:approved\n"
},
{
"kind": 1,
"language": "markdown",
"value": "⌛ Pending Approval"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS author:@me is:open is:pr review:required\n"
},
{
"kind": 1,
"language": "markdown",
"value": "⚠️ Changes Requested"
},
{
"kind": 2,
"language": "github-issues",
"value": "$REPOS author:@me is:open is:pr review:changes_requested\n"
}
]
26 changes: 26 additions & 0 deletions Source/vs/base/common/async.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,32 @@ export function raceTimeout<T>(promise: Promise<T>, timeout: number, onTimeout?:
]);
}

export function raceFilter<T>(promises: Promise<T>[], filter: (result: T) => boolean): Promise<T | undefined> {
return new Promise((resolve, reject) => {
if (promises.length === 0) {
resolve(undefined);
return;
}

let resolved = false;
let unresolvedCount = promises.length;
for (const promise of promises) {
promise.then(result => {
unresolvedCount--;
if (!resolved) {
if (filter(result)) {
resolved = true;
resolve(result);
} else if (unresolvedCount === 0) {
// Last one has to resolve the promise
resolve(undefined);
}
}
}).catch(reject);
}
});
}

export function asPromise<T>(callback: () => T | Thenable<T>): Promise<T> {
return new Promise<T>((resolve, reject) => {
const item = callback();
Expand Down
18 changes: 15 additions & 3 deletions Source/vs/code/node/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,26 @@ export async function main(argv: string[]): Promise<any> {

// Write File
else if (args['file-write']) {
const source = args._[0];
const target = args._[1];
const argsFile = args._[0];
if (!argsFile || !isAbsolute(argsFile) || !existsSync(argsFile) || !statSync(argsFile).isFile()) {
throw new Error('Using --file-write with invalid arguments.');
}

let source: string | undefined;
let target: string | undefined;
try {
const argsContents = JSON.parse(readFileSync(argsFile, 'utf8'));
source = argsContents.source;
target = argsContents.target;
} catch (error) {
throw new Error('Using --file-write with invalid arguments.');
}

// Windows: set the paths as allowed UNC paths given
// they are explicitly provided by the user as arguments
if (isWindows) {
for (const path of [source, target]) {
if (isUNC(path)) {
if (typeof path === 'string' && isUNC(path)) {
addUNCHostToAllowlist(URI.file(path).authority);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export class InlineCompletionsController extends Disposable {
private readonly _playAccessibilitySignal = observableSignal(this);

private readonly _fontFamily = this._editorObs.getOption(EditorOption.inlineSuggest).map(val => val.fontFamily);
private readonly _hideInlineEditOnSelectionChange = this._editorObs.getOption(EditorOption.inlineSuggest).map(val => true);

constructor(
public readonly editor: ICodeEditor,
Expand Down Expand Up @@ -178,6 +179,9 @@ export class InlineCompletionsController extends Disposable {

this._register(runOnChange(this._editorObs.selections, (_value, _, changes) => {
if (changes.some(e => e.reason === CursorChangeReason.Explicit || e.source === 'api')) {
if (!this._hideInlineEditOnSelectionChange.get() && this.model.get()?.stateWithInlineEdit.get()?.kind === 'inlineEdit') {
return;
}
this.model.get()?.stop();
}
}));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export class InlineCompletionsSource extends Disposable {
}

if (source.token.isCancellationRequested || this._store.isDisposed || this._textModel.getVersionId() !== request.versionId) {
updatedCompletions.dispose();
return false;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ export class InlineEditsAdapter extends Disposable {
e.provider.freeInlineEdit(e.result);
}
}
toString(): string {
return 'InlineEditsAdapter';
}
}));
}));
}
Expand Down
Loading

0 comments on commit 00b39c3

Please sign in to comment.