Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.2 compatibility #188

Closed
wants to merge 2 commits into from
Closed

PHP 7.2 compatibility #188

wants to merge 2 commits into from

Conversation

lostincode
Copy link
Contributor

Note: Explicitly passing NULL as the object is no longer allowed as of PHP 7.2.0. The parameter is still optional and calling get_class() without a parameter from inside a class will work, but passing NULL now emits an E_WARNING notice.

http://php.net/manual/en/function.get-class.php

@lostincode
Copy link
Contributor Author

related - CodeSleeve/laravel-stapler#132

@iredmedia
Copy link

Any progress on this :)?

marceloandrader added a commit to marceloandrader/stapler that referenced this pull request Feb 27, 2018
@marceloandrader
Fix PHP 7.2 compatibility issue CodeSleeve#188
dcd3b16
@michimawan
Copy link

michimawan commented Apr 3, 2019 •
edited
Loading

facebook/hhvm#6954
sebastianbergmann/phpunit#3320

seems the build failed because of hhvm issues, should we disable hhvm checking?
sebastian bergman also mention that hhvm is not supported

@lostincode
Copy link
Contributor Author

I think this repo is abandoned so I'm going to close my PR

@lostincode lostincode closed this Apr 8, 2019
@Alex-query
Copy link

Alex-query commented Aug 31, 2019 •
edited
Loading

i found a bad decidion use @ before $this->hasAttachedFile in __construct
// @$this->hasAttachedFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lostincode @iredmedia @michimawan @Alex-query