Fix cookie domain match (#5)

* stub webdriver cookies as objects over arrays * check for cookie domain with isset, not array_key_exists calling array_key_exists on classes implementing \ArrayAccess always returns false and emits a deprecation notice on 7.4
Codeception · Feb 15, 2020 · aa7c2d6 · aa7c2d6
1 parent a41fae6
commit aa7c2d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Codeception/Module/WebDriver.php b/src/Codeception/Module/WebDriver.php
@@ -3156,7 +3156,7 @@ public function deleteSessionSnapshot($name)
      */
     private function cookieDomainMatchesConfigUrl($cookie)
     {
-        if (!array_key_exists('domain', $cookie)) {
+        if (!isset($cookie['domain'])) {
             return true;
         }
 

diff --git a/tests/web/WebDriverTest.php b/tests/web/WebDriverTest.php
@@ -677,17 +677,17 @@ public function testSaveSessionSnapshotsExcludeInvalidCookieDomains()
         $fakeWdOptions = Stub::make('\Facebook\WebDriver\WebDriverOptions', [
             'getCookies' => Stub::atLeastOnce(function () {
                 return [
-                    [
+                    Cookie::createFromArray([
                         'name' => 'PHPSESSID',
                         'value' => '123456',
                         'path' => '/',
-                    ],
-                    [
+                    ]),
+                    Cookie::createFromArray([
                         'name' => '3rdParty',
                         'value' => '_value_',
                         'path' => '/',
                         'domain' => '.3rd-party.net',
-                    ],
+                    ])
                 ];
             }),
         ]);