-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cross-site scripting via svg file upload #856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girishpanchal30
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Aug 20, 2024
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Aug 20, 2024
vytisbulkevicius
requested review from
Soare-Robert-Daniel
and removed request for
abaicus
August 20, 2024 16:43
Soare-Robert-Daniel
approved these changes
Aug 21, 2024
@girishpanchal30 please use this library instead for sanitization https://github.com/Codeinwp/optimole-wp/blob/master/composer.json#L59, you can check Optimole on how is used. |
@selul Thank you for the suggestion, I've Implemented the library with the latest commit. |
🎉 This PR is included in version 2.10.37 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR I've filtered the SVG image content and removed the harmful code to fix the cross-site scripting vulnerability issue.
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/neve-pro-addon#2842