Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility issues with WordPress 6.7 and Elementor widgets #879

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

girishpanchal30
Copy link
Contributor

Summary

I have reverted the changes from the latest release, implemented new updates to fix the text domain loading issue in WordPress 6.7.*, and resolved the issue with the Elementor widget.

Will affect visual aspect of the product

Yes

Check before Pull Request is ready:

Closes #878

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 27, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 27, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 27, 2024

Plugin build for 3c43c93 is ready 🛎️!

@rodica-andronache
Copy link
Contributor

It's working well now

@vytisbulkevicius
Copy link
Contributor

@abaicus can you take an additional look here since fixing this problem caused issues on Neve and Hestia I want to double check if you don't see risks here.

Copy link
Contributor

@abaicus abaicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vytisbulkevicius things look good code-wise. If this works as expected in testing, we should be good to go. 👍🏻

@vytisbulkevicius
Copy link
Contributor

@girishpanchal30,

If I have Hestia theme installed and I activated OrbitFox from this build above, I get a fatal error:

Fatal error: Uncaught Error: Call to undefined function themeisle_hestia_require() in /s1-forgivefarm/wordpress/wp-content/plugins/themeisle-companion/obfx_modules/companion-legacy/init.php:219
Stack trace:
#0 /s1-forgivefarm/wordpress/wp-includes/class-wp-hook.php(324): Companion_Legacy_OBFX_Module->hestia_require()
#1 /s1-forgivefarm/wordpress/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#2 /s1-forgivefarm/wordpress/wp-includes/plugin.php(517): WP_Hook->do_action()
#3 /s1-forgivefarm/wordpress/wp-settings.php(684): do_action()
#4 /s1-forgivefarm/wordpress/wp-config.php(47): require_once('/s1-forgivefarm...')
#5 /s1-forgivefarm/wordpress/wp-load.php(50): require_once('/s1-forgivefarm...')
#6 /s1-forgivefarm/wordpress/wp-admin/admin.php(34): require_once('/s1-forgivefarm...')
#7 /s1-forgivefarm/wordpress/wp-admin/plugins.php(10): require_once('/s1-forgivefarm...')
#8 {main}
thrown in /s1-forgivefarm/wordpress/wp-content/plugins/themeisle-companion/obfx_modules/companion-legacy/init.php on line 219

image

@girishpanchal30
Copy link
Contributor Author

@vytisbulkevicius I've fixed it with my latest commit.

@vytisbulkevicius vytisbulkevicius merged commit e98d052 into development Dec 3, 2024
5 checks passed
@vytisbulkevicius vytisbulkevicius deleted the bugfix/878 branch December 3, 2024 11:57
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.10.42 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page builder widgets not appearing in Elementor anymore in latest update
6 participants