El3220/json generic parser #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SSRN into tests.py
ceteri
reviewed
Feb 25, 2020
There was a problem hiding this comment.
That's looking good!
Wrapping responses with the _ScholInfraResponse classes will help a lot later when we're measuring the performance timing of various API calls.
I've added a few things:
- attempted to resolve the
ResourceWarningdue torequests.Session()sockets... with an upgrade torequests >= 2.23.0plus thesession.close()and also an annotation in the unit tests, all to no avail! please remove thesession.close()or annotations if they're causing problems - got a headless mode for Selenium, which works for me, but please nix that code if it gives you any trouble
- given the headless Selenium, I moved the SSRN unit tests back into
tests.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53