Skip to content

Commit

Permalink
Don't shutdown UDS websockets.
Browse files Browse the repository at this point in the history
We have one to the Kit process - that is allowed to take way
longer than the ping time to respond, and it was not clear that
this new close behavior on ping/ping was introduced in:

	e8a3ceb

Which also appears to add a 2 second non-responding websocket
ping timeout for some reason (!?).

Signed-off-by: Michael Meeks <[email protected]>
Change-Id: Iad74f253bdac5636757b130b299b5deacda658db
  • Loading branch information
mmeeks committed Oct 26, 2024
1 parent ef6ccef commit 8835ff0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/WebSocketHandler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,8 @@ class WebSocketHandler : public ProtocolHandlerInterface
LOG_WRN("CheckTimeout: Timeout websocket: Ping: last " << _pingMicroS.last() << "us, avg "
<< _pingMicroS.average() << "us >= " << _pingTimeout.count() << "us over "
<< (int)_pingMicroS.duration() << "s");
shutdownSilent();
if( isIPType() )
shutdownSilent();
return true;
}
if (!_pingMicroS.initialized() || (_pingPeriod > std::chrono::microseconds::zero() &&
Expand Down

0 comments on commit 8835ff0

Please sign in to comment.