Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last arg to findOrCreateDocBroker is always null #10552

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Nov 20, 2024

Change-Id: I9f542a0d4093a102c09d77f3be3cccb635d7a721

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@caolanm caolanm force-pushed the private/caolan/arg_is_always_null branch from 54edb2b to 1142172 Compare November 21, 2024 10:31
Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: I9f542a0d4093a102c09d77f3be3cccb635d7a721
Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: I813540cc7e2524e862b559bae0bd11fc69b63f39
Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: I5c90b48629c52cf4db76a174c15470d9e48294d4
Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: I288872f5dc7a4680dc88c7bb2b6dea757bdaf2c2
@caolanm caolanm force-pushed the private/caolan/arg_is_always_null branch from 1142172 to 51cdc81 Compare November 21, 2024 21:01
@caolanm caolanm requested a review from Ashod November 21, 2024 23:14
@caolanm
Copy link
Contributor Author

caolanm commented Nov 21, 2024

@Ashod just pulling a loose thread here, I saw that the last arg to findOrCreateDocBroker was always null in practice and I wonder if this is some work in progress to be completed sometime or something that can be cleaned up like so.

@Ashod
Copy link
Contributor

Ashod commented Dec 2, 2024

@Ashod just pulling a loose thread here, I saw that the last arg to findOrCreateDocBroker was always null in practice and I wonder if this is some work in progress to be completed sometime or something that can be cleaned up like so.

Interesting observation! Thanks for bringing to my attention. downloadAdvance was working. Looks like something was changed that disabled it, effectively. I'll look into it, but of course it's best to download in parallel to serving the pages, to reduce the load latency visible to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

2 participants