Add cypress tests for shortcut to save comments

[meven]

Using Ctrl+Enter in calc and writer.

See dce4671

Context: #10622 (review)

Change-Id: Ic7e947623aac6345e4ad9c92a9454dfb5b2a4c2e

• Resolves: #
• Target version: master

Summary

TODO

• ...

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[vmiklos]

Thanks, looks good.

Nits:

• good to partition your test code to given (setup), when (here: do the ctrl-enter), then (assert) parts, so when it fails, it's more obvious to the next person if the interesting part of the test failed as intended (to catch badness) or it's something else
• you make my poor live a bit easier if you only request review when CI passed (and not before), so I can also merge after approval :-)

Thanks.

[meven]

you make my poor live a bit easier if you only request review when CI passed (and not before), so I can also merge after approval :-)

Sorry, since CI is very slow, this is a better practice indeed.

good to partition your test code to given (setup), when (here: do the ctrl-enter), then (assert) parts, so when it fails, it's more obvious to the next person if the interesting part of the test failed as intended (to catch badness) or it's something else

I followed the test existing construction but indeed, Given, When Then makes things a lot easier to maintain, and show an example to improve the other tests in those files.

Thanks

[vmiklos]

https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04_cypress_desktop/3010/console failed in calc/annotation_spec.js, seems that include your new test, if you search for "Modify and Save using shortcut Ctrl+Enter". Do you have a guess what's the problem there?

[meven]

https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04_cypress_desktop/3010/console failed in calc/annotation_spec.js, seems that include your new test, if you search for "Modify and Save using shortcut Ctrl+Enter". Do you have a guess what's the problem there?

Not yet, I have been investigating.

Writer is the same.
The weird part is it worked before, and I didn't change code, so it seems spurious, still I want it stable.

I have been investigating:

                    
                    Timed out retrying after 20000ms: Expected to find element: `#document-canvas`, but never found it. Queried from:
                    
                                  > cy.get(#coolframe, [object Object]).its(0.contentDocument, [object Object])
                    
                    /home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04_cypress_desktop/cypress_test/support/index.js:181:1
                      179 | 		return cy.get(cy.cActiveFrame, {log: false})
                      180 | 			.its('0.contentDocument', {log: false})
                    > 181 | 			.find(selector, optionsWithLogFalse);
                          | ^
                      182 | 	} else {
                      183 | 		return cy.get(cy.cActiveFrame, optionsWithLogFalse)
                      184 | 			.its('0.contentDocument', {log: false});
          cy:log ✱  Finishing test: integration_tests/desktop/calc/annotation_spec.js / Annotation Tests / Modify and Save using shortcut Ctrl+Enter

[eszkadev]

Requires some fixes, cypress faisl seems to be related.
Please also rebase as now cypress is more stable in general.