Major CodeQA - 20250119 #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Update Rust compiler for csharp_bindings to rustc 1.84.0 (9fc6b4312 2025-01-07) (Stable) + Remove dependency to MSVCRT library (Manual VC++ 2019/2022 Redist installation should no longer be needed) + Update libwebp libraries to: https://github.com/webmproject/libwebp/tree/f8f241071001e1a3807f34a26a03a742ea843458 + Favor size build + Recompile using MSVC 2022 (19.43.34618)
Fix MD5 instance not disposed after use
+ Fix some breaking changes due to moving parts on Microsoft.Xaml.Behaviors.WinUI.Managed
This reverts commit 5c6d361.
bagusnl
reviewed
Jan 21, 2025
bagusnl
requested changes
Jan 21, 2025
CollapseLauncher/Classes/GameManagement/GameVersion/BaseClass/GameVersionBase.cs
Outdated
Show resolved
Hide resolved
Force update submodules to the merge-base repo via bootstrap
+ Pack the libraries and extract it only if AOT compilation is used + Ensure to use Link Target Optimization (LTO) on linker + (Hopefully) Fix some missing symbols at MachineIndependent.lib
+ Downgrade the Windows SDK to 10.0.22621.0 while compiling static libs. This fixed inconsistency and "missing symbol" error at some libraries. + Change to compile all libraries to use /MT (libucrt.lib). This hopefully remove the dependency for the users to install Visual C++ Redist 2022. + Use full LTO for Rust library, csharp_bindings. + Prefer to use speed + inline optimization (/O2 + /Ob2 + /Ot + /Oi) instead of size (/O1 + /Ob1 + /Os)
Replacing the use of ``new DriveInfo().IsExist``. Instead, use ``Directory.Exists()`` as ``IsExist`` property actually uses the same ``Directory.Exists()`` under the code.
+ This allows some trick, like game conversion via Game Repair possible for ZZZ
WTF GitHub Desktop?
- [INTENTIONAL] Downgrade SDK BuildTools Its to match the SDK we actually use to build the app - Explicitly use .NET ILLink Task v9.0.1 Idk why the SDK is so ADAMANT on using v9.0.0
Halp, please make it the last
|
Tanks!Sidenote: Add "Wi" after "Joko" name and we are good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
This PR contains huge CodeQA and some code refactoring for some functionalities, which hopefully improve the maintainability of the codebase further.
What's changed?
Hashextension for hashingFileStream,string,Span<T>andFileInfowith both synchronous and asynchronous version of the methods. The methods uses generic type of any member ofHashAlgorithm(Such as:MD5,SHA*,HMACSHA*, etc.) andNonCryptographicHashAlgorithm(Such as:Crc32,XxHash*, etc.) to specify which kind of hash to be used.InternalAppJSONContextmembers into its ownJsonContextes.csharp_bindingsto rustc 1.84.0 (9fc6b4312 2025-01-07) (Stable)MSVCRTlibrary (Manual VC++ 2019/2022 Redist installation should no longer be needed) and fully utilizeUCRTas its runtime library.csharp_bindingsto use full LTO.PR Status :
Templates
Changelog Prefixes