-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev server does not restart on save #544
Conversation
9fed2d0
to
bc456d2
Compare
f63914a
to
b25e8b0
Compare
Also unlocks vitest from 2.1.6 - no requirement to be pinned to that version. Partially reverts: a179d5c
Similar to previous impl., but uses watch mode detection instead of script.
b25e8b0
to
3124c81
Compare
What is the recommended way to build/watch both packages? Currently the preload is not included. |
We could use a proper system for this, but it has not been addressed because preload is such a micro-project that it felt like an ineffective use of time to even add auto recompile. It wouldn't be HMR (no practical solutions for this), A fix that would auto recompile and make the app restart would be to just add a vite plugin. If this is an actual issue though I'd say there's something else fundamentally wrong here. It may be addressed in a PR that will land soon after the maintenance / validation work. Edit: Workaround. Does not require restart, just need to refresh the page -
|
Thanks! Workaround seems good! We should add that to the README. |
vite.main.config.ts
tovite.config.ts
+ update refslaunchdev.js
tolaunchCI.js
- now builds and loads an instance for CI tests onlyvite build --watch
┆Issue is synchronized with this Notion page by Unito