Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify electron build after yarn:make #642

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Verify electron build after yarn:make #642

merged 5 commits into from
Jan 17, 2025

Conversation

robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Jan 16, 2025

  • Add uv to electron builder local build config (builder-debug.config.ts)
  • Verify that uv, ComfyUI, and UI directories exist in resulting build
  • Make downloading uv part of the yarn make:assets command

Fixes: currently uv is not part of the yarn make build artifact. We had an extra step in the todesktop build to download it. This PR adds everything to yarn:make:assets do you only need to run a single command to get everything needed to start the application.

@robinjhuang robinjhuang requested review from a team as code owners January 16, 2025 19:50
@robinjhuang robinjhuang merged commit ac1c649 into main Jan 17, 2025
6 checks passed
@robinjhuang robinjhuang deleted the rh-verify branch January 17, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant