Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add unit tests for 100% coverage of comfyServerConfig #691

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Jan 21, 2025

This PR adds unit tests on remaining branches in comfyServerConfig, bringing to 100% coverage:

Selection_790

The untested function is marked as deprecated and never called.

Newly tested functions are:

  • exists
  • writeConfigFile
  • createConfigFile
  • getConfigFile
  • getConfigFromRepoPath
  • Test for final untested branch in readBasePathFromConfig

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner January 21, 2025 23:32
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@huchenlei huchenlei merged commit f63efeb into main Jan 22, 2025
6 checks passed
@huchenlei huchenlei deleted the unit-test/server-config-p2 branch January 22, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants