[feat] 이미지 업로드 기능을 구현한다. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpeel5839
commented
Jun 14, 2024
Comment on lines
128
to
129
| List<Image> images = imageRepository.findAllByIdeaId(ideaId); | ||
| IdeaDetailResponse ideaDetailResponse = IdeaDetailResponse.of(tokenMemberId, idea, images); |
There was a problem hiding this comment.
요것만 바뀐거에요! 아래는 option+command+L눌러서 바뀌었어용 호호호
kpeel5839
commented
Jun 14, 2024
Comment on lines
+50
to
+52
| // S3 | ||
| implementation platform('com.amazonaws:aws-java-sdk-bom:1.11.1000') | ||
| implementation 'com.amazonaws:aws-java-sdk-s3' |
There was a problem hiding this comment.
요것만 추가했어요! 의존성에서는용
parkmuhyeun
reviewed
Jun 14, 2024
Comment on lines
47
to
79
| private String upload(MultipartFile multipartFile) { | ||
| try { | ||
| UploadFile uploadFile = UploadFile.from(multipartFile); | ||
| fileUpload(uploadFile); | ||
| return uploadFile.getOriginalFilename(); | ||
| } catch (IOException exception) { | ||
| throw new RuntimeException(exception); | ||
| } | ||
| } | ||
|
|
||
| private void fileUpload(MultipartFile multipartFile) throws IOException { | ||
| File tempFile = null; | ||
|
|
||
| try { | ||
| tempFile = File.createTempFile("upload_", ".tmp"); | ||
| multipartFile.transferTo(tempFile); | ||
| amazonS3.putObject(new PutObjectRequest( | ||
| bucket, | ||
| multipartFile.getOriginalFilename(), | ||
| tempFile | ||
| )); | ||
| } catch (IOException exception) { | ||
| throw new IOException(exception); | ||
| } finally { | ||
| removeTempFileIfExists(tempFile); | ||
| } | ||
| } | ||
|
|
||
| private void removeTempFileIfExists(File tempFile) { | ||
| if (Objects.nonNull(tempFile) && tempFile.exists()) { | ||
| tempFile.delete(); | ||
| } | ||
| } |
There was a problem hiding this comment.
얘네는 서비스에말고 저장소(s3,.. )에 저장하는 책임을 담당하는 객체 만들어주면 더 좋겠네영
There was a problem hiding this comment.
사실 처음에 그렇게 하려고 했었는데, Service가 다른 Service를 참조하는 모양이 조금 그랬었어요.
그냥 그렇게 하는게 나으려나요?
There was a problem hiding this comment.
분리하면 걔는 service라기 보다는 하나의 역할을 하는 객체인데 주입할 수 있는 컴포넌트에 가깝다고 생각함당(한단계 낮은)
Comment on lines
119
to
122
| private void deleteImage(Image image) { | ||
| amazonS3.deleteObject(new DeleteObjectRequest(bucket, image.getImageUrl())); | ||
| imageRepository.delete(image); | ||
| } |
Comment on lines
12
to
13
| @Value("${cloud-front-url}") | ||
| private static String cloudFrontUrl; |
There was a problem hiding this comment.
얘는 밖에서 만들어주는게 좋지 않나용
이렇게하면 이거 필요한 레코드마다 다 넣어줘야 될거같아서영
There was a problem hiding this comment.
레코드에서 말고 Service 딴에서 말씀하시는건가용?
| } | ||
|
|
||
| @PostMapping(value = "/{ideaId}", consumes = MediaType.MULTIPART_FORM_DATA_VALUE) | ||
| public ResponseEntity<Void> saveImage( |
There was a problem hiding this comment.
이렇게 되면 API 2번 날리는 구조인거 같은데 트랜잭션 보장이 안되서 뭔가 보강을 하거나 수정해야 될거 같아용
dnd2dnd
approved these changes
Jun 15, 2024
parkmuhyeun
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
#90 한 작업은 해당 이슈에 있습니다.
🙋🏻 More
이번에 최대한 의존성을 많이 신경썼어요.
Image 패키지는 최대한 다른 패키지를 참조하지 않도록 노력했습니다!
그 과정에서 IdeaValidator가 생기게 되었고요.
또한, Mocking Test를 하기가 너무 싫어서 중요한 로직들은 ImageChecker로 뺐어요!