-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONT-93: Forecast microservice #89
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I get it correctly, these files should be removed:
- continuity.forecast/telescope-multi/R/.RData
- continuity.forecast/telescope-multi/R/.Rhistory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess also all the files in continuity.forecast/telescope-multi/R/logs/ should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost good, but there are some minor flaws which should be corrected.
@@ -12,9 +12,11 @@ dependencies { | |||
compile project(':continuity.api') | |||
compile project(':continuity.commons') | |||
|
|||
compile files('lib/behaviormodelextractor_forecast.jar') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should upload this to the Nexus as a new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I also need this for my workload modularization approach
docker-compose-debug.yml
Outdated
- --eureka.uri=http://eureka:8761/eureka | ||
|
||
forecast: | ||
image: continuityproject/session-logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be continuityproject/forecast
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups true :)
@Henning-Schulz, could you please wait to integrate this. I'll create a pull request which consists of CONT-93 and CONT-126. |
No description provided.