Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32 in app chat 1 #55

Merged
merged 32 commits into from
Jan 3, 2023
Merged

32 in app chat 1 #55

merged 32 commits into from
Jan 3, 2023

Conversation

itsalb3rt
Copy link
Member

#35

@itsalb3rt
feat
4a1f431 
* Added i18n text
@itsalb3rt
feat
f34b414 
* Added notification icon to the menu
@itsalb3rt
feat
535d355 
* Added i18n text
@itsalb3rt
feat
2c78cc5 
* Added notification real time event
* Added notification funcionality
@itsalb3rt
feat
41e1be7 
* Added i18n text
@itsalb3rt
feat
6cd2ee2 
* Added read all button
@itsalb3rt
feat
d6ecd13 
* Added i18n text
@itsalb3rt
feat
a7eaba7 
* Created method to read all notifications
@itsalb3rt
refactor
9eaad39 
* Change messages notification body
@itsalb3rt
feat
f2a0cb3 
* Added i18n text
@itsalb3rt
feat
d5c5392 
* Handle the notification click
@itsalb3rt
refactor
8557945 
* Handle the chat id from the URL
@itsalb3rt
feat
f2c7bf9 
* Handle the click of the notification
@itsalb3rt
feat
3eefc31 
* Added i18n text
@itsalb3rt
refactor
3a2e693 
* Created method to get the notification title
@itsalb3rt
feat
897c568 
* Used the get notification title method
@itsalb3rt
feat
a6026e2 
* Handle the schedule notification click
@itsalb3rt
fix
05850c0 
* Wrong property of the space id
@itsalb3rt
feat
78e08ae 
* Added prop to create a identify
@itsalb3rt
feat
b6fbf9e 
* Added highlight to the schedule cards when the user comes from a notification
@itsalb3rt
feat
a89a9c8 
* Added the "to_user" field to message body
@itsalb3rt
feat
94f65c7 
* Added the new notification to the notifications object
@itsalb3rt
refactor
f2cfc36 
* Removed debug method
@itsalb3rt
feat
aeadf87 
* Added funcionality to the mark all as read button
@itsalb3rt
feat
c2abb01 
* Created method to mark single notification as read
@itsalb3rt
refactor
6e0e7d7 
* Removed the profile icon
* Added the profile option to the avatar action
@itsalb3rt
refactor
f79cf0f 
* Removed notification logic
@itsalb3rt
refactor
f202533 
* Removed unused import
@itsalb3rt
feat
bc32b45 
* Created a notfiications panel component
@itsalb3rt
feat
336437b 
* Added notification panel
@itsalb3rt
feat
649deec 
* Added icons to the notifications
@itsalb3rt itsalb3rt linked an issue Dec 31, 2022 that may be closed by this pull request
In-app Chat and notifications #32
Open
9 tasks
@itsalb3rt
feat
f39962f 
* Added margin to the time ago
@itsalb3rt itsalb3rt merged commit fc3cc05 into main Jan 3, 2023
pcabreram1234
pcabreram1234 reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@pcabreram1234 pcabreram1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the $q var in the previous comment, every else is good and the code is easy to read

src/components/Interface/NotificationsPanel.vue
export default {
name: "ComponentNotificationsPanel",
setup() {
const $q = useQuasar();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This var is not used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I checking this asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcabreram1234 pcabreram1234 pcabreram1234 left review comments

@rafieltq rafieltq Awaiting requested review from rafieltq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In-app Chat and notifications
2 participants
@itsalb3rt @pcabreram1234