Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoNotShowCatalogStarsInMaskedRegionsOfAstrometryReport #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DoNotShowCatalogStarsInMaskedRegionsOfAstrometryReport #242

wants to merge 1 commit into from

Conversation

MurrayForbes
Copy link
Contributor

Filter out the catalog stars in the masked regions of the image of the Astrometry report.

@markmac99
Copy link
Contributor

Could you clarify the problem that this fixes please? I am not sure i see why we need to make the change.

A couple of other points:
recalibrated is correctly spelled as one word, not hyphenated.
also note that "dict" is normal usage for the python dictionary type
sorry if these seem small points but the changes don't add to the clarity or fix errors in the comments, and its likely the next maintainer will change them back, so i would suggest we leave the current spelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MurrayForbes @markmac99