-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize mask, flat, and dark loading with caching #382
base: prerelease
Are you sure you want to change the base?
Conversation
This PR just caches the non-bin versions. Should I cache the bins too? Not sure how often the conversions occur, but it wouldn’t be too much work. |
Can test on Pi4, Pi5 tonight. |
Thank you Dave. |
It was running fine on Debian, Pi5, 4 last night. I'll check after sunrise, happy to leave those stations there. |
I'm testing this version tonight. It caches all binned and non-binned mask, dark, and flat files. The cache should update incrementally if there are any changes to the files. This should reduce I/O operations significantly and decrease CPU load somewhat, as binning is only done when a new file is detected, and checking for all-white masks is only performed when a new mask file is detected - as opposed to every time the files are used (which is continuously). So far, the only testing I've done is to confirm that it doesn't crash on MCL using mask-only operation and that it loads the correct mask. What needs to be tested:
I'm unsure about the actual usage of dark and flat files. I note that dark is disabled by default, and there are currently no options exposed in the config to enable it. |
I verified the cache does update when a mask file is updated. Now, if someone could test the flat and dark functions which I have no experience with. |
Optimize image calibration loading with caching and improved logging (issue #336 )
This commit should reduces strain on SD cards and hopefully speed up performance on slow storage.
Tested on MCL. Need testing on Pi 4 and 3.