Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax CID validation pattern #335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

krutsko
Copy link

@krutsko krutsko commented Nov 15, 2024

we use ArgoCD helm template | argo-vault-plugin to pass CID from Vault and thus we have to apply dirty hack to workaround this

The CID with used doesn't match the pattern from the helm chart, so we need to apply dirty hack to workaround this.
@ChristianCiach
Copy link

We have a similar workflow in place. But you should be able to call helm template --skip-schema-validation instead, which I believe to be the better solution.

@krutsko
Copy link
Author

krutsko commented Dec 12, 2024

Yes, probably, but our current tooling does not allow to call helm template --skip-schema-validation. Also, I don't want to skip validation altogether, it's useful.
But, instead, I think it makes sense to relax the cumbersome validation pattern. It means, I don't forget to set some value here (if it doesn't correct, it's my fault in the end). And at the same time, all other fields will pass validation according to the scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants