This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
PR #12
Open
PR #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 4, 2022 00:26
… changes and fixes
webmaster442
reviewed
Dec 7, 2022
| this.IsFree = false; | ||
| CookingTime = meat.CookingTime; | ||
| Console.WriteLine(meat.amount + " db " + meat.GetType().Name + " bekerült a sütőbe..."); | ||
| Task.Delay(CookingTime).Wait(); |
There was a problem hiding this comment.
ezt await-el is be lehetett volna várni :)
| if (NormalFryers[i].IsFree) { return i; } | ||
| } | ||
| } | ||
| else throw new ArgumentException("Rossz paraméter! Elvárt: bool"); |
There was a problem hiding this comment.
Hmmm :D Meglepődnék, ha bool bemeneti típusból nem bool jönne C# esetén
| while (input != "q") | ||
| { | ||
| input = Console.ReadLine(); | ||
| switch (input) |
There was a problem hiding this comment.
minden input-ra lehetett volna egy külön metódus
| @@ -0,0 +1,63 @@ | |||
| ############################################################################### | |||
There was a problem hiding this comment.
Szép munka, pár apróságot leszámítva :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maradt 1-2 rész a kódban, ami nincs használva, a védés keretei között beszélhetek róluk, miket szántam plusz funkcionalitásnak, amit felfoghatunk "Későbbi fejlesztési ötlet" címszó alatt is.