Quiz app project #39
Open
Quiz app project #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster442
reviewed
Dec 9, 2024
| @@ -0,0 +1,269 @@ | |||
| # Remove the line below if you want to inherit .editorconfig settings from higher directories | |||
| using System.Threading.Tasks; | ||
|
|
||
| namespace IZT6ZK.Assists; | ||
| internal class ConsoleHelper |
There was a problem hiding this comment.
A Helper suffix-et én architektként nagyon nagyon nem szeretem, mégpedig azért mert szerintem az esetek 90%-ban arra utal, hogy gond adódott az elnevezéssel :D. Ugyan ilyen semmit mondó nevek még a Context és a Utilities. Ezek használata kerülendő.
| { | ||
| Console.WriteLine("Write 'quit all' if you want to quit all of the questions.\n"); | ||
| } | ||
| public static string ReadAndWrite(string whatWeWantToAskFromUser) |
There was a problem hiding this comment.
Single responsibility?
| switch (stateQuestionReading) | ||
| { | ||
| case CreateQuestionStateMachine.QuestionReading: | ||
| input = ConsoleHelper.ReadAndWrite("your question"); |
There was a problem hiding this comment.
Huhh, It a Case minden ága lehetne egy külön metódus is akár, mert ez így baromira átláthatatlan.
|
|
||
| namespace IZT6ZK.Db; | ||
|
|
||
| internal interface IDbManager |
There was a problem hiding this comment.
Interfész 👍 , de a feladatai alapján ennek legalább kettőnek kellene lennie szerintem.
| } | ||
| protected override void OnConfiguring(DbContextOptionsBuilder options) | ||
| => options | ||
| .UseSqlite($"Data Source=questions.db"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2