Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Welcome message #1182

Merged

Conversation

lapolonio
Copy link
Contributor

Cool things:
Last item in list can have a comma
Rails updates automajically on save

I rule and have completed some work on Case Manager that's ready for review!

Add another welcome message (really just copied)

It relates to the following issue #s:

Cool things:
Last item in list can have a comma
Rails updates automajically on save
@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #1182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          55       55           
  Lines        1195     1195           
=======================================
  Hits         1139     1139           
  Misses         56       56
Impacted Files Coverage Δ
app/helpers/welcome_message_helper.rb 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc842d...c6410b8. Read the comment docs.

Copy link
Member

@colinxfleming colinxfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, when I picked up ruby in 2013, trailing commas on arrays were a real bane of my existence. I had no idea they switched this over, thanks a ton for cluing me into that! 💯

@colinxfleming colinxfleming merged commit 1f14139 into DARIAEngineering:master Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants