Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update welcome_message_helper.rb #2258

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

WendellBeane
Copy link
Contributor

I rule and have completed some work on Case Manager that's ready for review!

I included a greeting message

This pull request makes the following changes:

  • My greeting message

(If there are changes to the views, please include a screenshot so we know what to look for!)

It relates to the following issue #s:

For reviewer:

  • Adjust the title to explain what it does for the notification email to the listserv.
  • Tag this PR:
    • feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
    • dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.
  • If it contains neither, no need to tag this PR.

Copy link
Member

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Welcome! 🎉 :shipit:

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #2258 (bba8ccd) into main (bd21b9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2258   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          79       79           
  Lines        1653     1653           
=======================================
  Hits         1591     1591           
  Misses         62       62           
Impacted Files Coverage Δ
app/helpers/welcome_message_helper.rb 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd21b9e...bba8ccd. Read the comment docs.

@lomky lomky merged commit 2f4a4d1 into DARIAEngineering:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants