Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept dfs file with zero timestep #619

Closed
wants to merge 17 commits into from
Closed

Accept dfs file with zero timestep #619

wants to merge 17 commits into from

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Nov 7, 2023

Some engines, e.g. MIKE She specifies a file $\Delta t = 0.0$, which could not be correctly interpreted by MIKE IO (actually pd.DateTimeIndex).

This PR warns when $\Delta t <= 0.0$ or raises an error if number of timesteps > 1 (where the files would be invalid).

Example of reading a previously unreadable file:
image

@ecomodeller ecomodeller linked an issue Nov 7, 2023 that may be closed by this pull request
@ecomodeller ecomodeller closed this Nov 7, 2023
@ecomodeller
Copy link
Member Author

Bad starting point😶

@ecomodeller ecomodeller deleted the zero_dt branch January 21, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mikeio fails when reading preprocessed layer information
1 participant