Merge pull request #292 from DHI/check-kwargs-valid

Check kwargs valid

modelskill/comparison/_collection.py

@@ -422,6 +422,7 @@ def skill(
         # TODO remove in v1.1
         model, start, end, area = _get_deprecated_args(kwargs)
         observation, variable = _get_deprecated_obs_var_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         cmp = self.sel(
             model=model,
@@ -530,6 +531,7 @@ def spatial_skill(
 
         model, start, end, area = _get_deprecated_args(kwargs)
         observation, variable = _get_deprecated_obs_var_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         metrics = _parse_metric(metrics, self.metrics, return_list=True)
 
@@ -677,6 +679,7 @@ def mean_skill(
         # TODO remove in v1.1
         model, start, end, area = _get_deprecated_args(kwargs)
         observation, variable = _get_deprecated_obs_var_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         # filter data
         cmp = self.sel(
@@ -769,6 +772,7 @@ def mean_skill_points(
         # TODO remove in v1.1
         model, start, end, area = _get_deprecated_args(kwargs)
         observation, variable = _get_deprecated_obs_var_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         # filter data
         cmp = self.sel(
@@ -905,6 +909,7 @@ def score(
 
         model, start, end, area = _get_deprecated_args(kwargs)
         observation, variable = _get_deprecated_obs_var_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         if model is None:
             models = self.mod_names
@@ -960,6 +965,7 @@ def taylor(
 
         model, start, end, area = _get_deprecated_args(kwargs)
         observation, variable = _get_deprecated_obs_var_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         cmp = self.sel(
             model=model,

modelskill/comparison/_comparison.py

@@ -958,6 +958,7 @@ def skill(
 
         # TODO remove in v1.1
         model, start, end, area = _get_deprecated_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         cmp = self.sel(
             model=model,
@@ -1026,6 +1027,7 @@ def score(
 
         # TODO remove in v1.1
         model, start, end, area = _get_deprecated_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         s = self.skill(
             metrics=[metric],
@@ -1108,6 +1110,7 @@ def spatial_skill(
 
         # TODO remove in v1.1
         model, start, end, area = _get_deprecated_args(kwargs)
+        assert kwargs == {}, f"Unknown keyword arguments: {kwargs}"
 
         cmp = self.sel(
             model=model,

tests/test_aggregated_skill.py

@@ -57,6 +57,11 @@ def test_skill(cc1):
     assert "bias" in repr(s)
 
 
+def test_skill_bad_args(cc1):
+    with pytest.raises(AssertionError):
+        cc1.skill(nonexisting_arg=1)
+
+
 def test_skill_multi_model(cc2):
     s = cc2.skill(metrics=["rmse", "bias"])