Merge pull request #285 from DHI/update-bins-default-2

Default number of bins in scatter plot --- too many defaults?
DHI · Nov 26, 2023 · c23d91c · c23d91c
2 parents 85cef68 + fdb1167
commit c23d91c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/modelskill/comparison/_collection.py b/modelskill/comparison/_collection.py
@@ -563,7 +563,7 @@ def spatial_skill(
     def scatter(
         self,
         *,
-        bins=20,
+        bins=120,
         quantiles=None,
         fit_to_quantiles=False,
         show_points=None,

diff --git a/modelskill/comparison/_collection_plotter.py b/modelskill/comparison/_collection_plotter.py
@@ -22,7 +22,7 @@ def scatter(
         self,
         *,
         model=None,
-        bins: int | float = 20,
+        bins: int | float = 120,
         quantiles: int | Sequence[float] | None = None,
         fit_to_quantiles: bool = False,
         show_points: bool | int | float | None = None,

diff --git a/modelskill/comparison/_comparer_plotter.py b/modelskill/comparison/_comparer_plotter.py
@@ -399,7 +399,7 @@ def scatter(
         self,
         *,
         model=None,
-        bins: int | float = 20,
+        bins: int | float = 120,
         quantiles: int | Sequence[float] | None = None,
         fit_to_quantiles: bool = False,
         show_points: bool | int | float | None = None,

diff --git a/modelskill/comparison/_comparison.py b/modelskill/comparison/_comparison.py
@@ -1165,7 +1165,7 @@ def remove_bias(self, correct="Model"):
     def scatter(
         self,
         *,
-        bins=20,
+        bins=120,
         quantiles=None,
         fit_to_quantiles=False,
         show_points=None,